gno
gno copied to clipboard
feat(gnodev): add more configuration flags for server usage
partially address suggestion from https://github.com/gnolang/gno/pull/1583
add multiple flags for server usage
-
-max-gas
set per block maximum gas -
-no-replay
disable replay on reload (reload have the same effect as reset) -
-node-rpc-listener
set node rpc listener -
-chain-id
set node ChainID
Update the default ChainID
to dev
for gnodev
for better sense and convenience.
Contributors' checklist...
- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a
BREAKING CHANGE: xxx
message was included in the description - [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to generated graphs, if any. More info here.
Codecov Report
Attention: Patch coverage is 0%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 47.52%. Comparing base (
82a36f9
) to head (2856933
).
Files | Patch % | Lines |
---|---|---|
gno.land/pkg/gnoland/node_inmemory.go | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1622 +/- ##
==========================================
+ Coverage 44.81% 47.52% +2.71%
==========================================
Files 460 388 -72
Lines 67725 61400 -6325
==========================================
- Hits 30353 29183 -1170
+ Misses 34834 29775 -5059
+ Partials 2538 2442 -96
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Flags -max-gaz
, -node-rpc-listener
and -web-listener
work as expected. In addition to -node-rpc-listener
, can you add -node-chainid
?
I ran the stress test with -no-replay=true
, but it doesn't seem to save memory. (I see in the code where the NoReplay
flag is set, but I don't see where it's used. Is this implemented?)
Flags
-max-gaz
,-node-rpc-listener
and-web-listener
work as expected. In addition to-node-rpc-listener
, can you add-node-chainid
?
~unfortunately i cannot pass ChainID as it's unexposed~
Sorry, it's actually doable. I've added the flag in 9da15783227bb51903bce3462549badd34f080f5.
I ran the stress test with -no-replay=true, but it doesn't seem to save memory. (I see in the code where the NoReplay flag is set, but I don't see where it's used. Is this implemented?)
no-replay
will only disable replay on reload, memory will still be used to store txs, I need to had a way to change db backend to store tx on disk to be able to save memory usage