gno icon indicating copy to clipboard operation
gno copied to clipboard

feat: Add the stdlib_diff tool to compare gno and go standard libraries

Open FloRichardAloeCorp opened this issue 1 year ago • 2 comments

As requested by the issue https://github.com/gnolang/gno/issues/1310, the aim of this pull request is to add a tool under the misc directory to compare the Gno and Go standard libraries.

The tool generates a differences report per package.

To test the tool, build it, and refer to the README for usage instructions. The tool can be used in both ways: comparing Go to Gno or comparing Gno to Go.

I'm questioning the relevance of adding unit tests to this tool. If you believe it needs some, just let me know!

Contributors' checklist...
  • [x] Added new tests, or not needed, or not feasible
  • [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • [x] Updated the official documentation or not needed
  • [x ] No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • [x] Added references to related issues and PRs
  • [x ] Provided any useful hints for running manual tests
  • [x ] Added new benchmarks to generated graphs, if any. More info here.

FloRichardAloeCorp avatar Dec 08 '23 10:12 FloRichardAloeCorp

@FloRichardAloeCorp I see some comments are still pending (including what I added in the top-level comment). Would you like me to do a second round of review or are you still making changes?

Thanks!

thehowl avatar Jan 08 '24 15:01 thehowl

@thehowl I still have work to do, I was waiting for your answers. I ping you back when I have finished.

FloRichardAloeCorp avatar Jan 10 '24 07:01 FloRichardAloeCorp

@thehowl what's the status on this PR?

zivkovicmilos avatar Jun 14 '24 09:06 zivkovicmilos

@zivkovicmilos I'll get around to finishing what Florian started, eventually :melting_face:

thehowl avatar Jun 24 '24 15:06 thehowl

Being continued in #2869; closing.

thehowl avatar Oct 02 '24 13:10 thehowl