Guillaume Nodet

Results 422 comments of Guillaume Nodet

> It's a great feature. Maybe we shouldn't download some binaries per default but ask the user before downloading the idk? Not sure to understand. The default behaviour is unchanged,...

> Great feature! From a user perspective (especially if I wear the Enterprise and not the Open Source Developer one) I have few things: > > * Do you plan...

> > I sort of surprised that an enterprise that is that particular about security would use maven-wrapper in the first place, but to each their own. 🤷‍♂️ > >...

FWIW, Maven 4 should not be affected by the problem, as the switch to the NIO2/Path API has removed most calls to `getCanonicalFile()`. I don't have any Windows VM available...

I think the use of `getCanonicalFile` and `toRealPath` should both be removed from the code base. There's no good reason why Maven should use those when dealing with projects. I...

We do have the needed infrastructure and we do look for the `CI` env variable. For example, it's used here: https://github.com/apache/maven/blob/335baf58fb499ee4e14cd1fe0c3cc2c1c9ed4ffe/impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java#L724 We actually do disable transfer logging in CI jobs:...

@TheRealHaui You need to run mvn spotless:apply to correctly format the source code.

Currently, only [execution events](https://github.com/apache/maven/blob/master/api/maven-api-core/src/main/java/org/apache/maven/api/EventType.java#L29-L47) are sent in the new API. Resolution requests are currently not intercepted. Unfortunately, the new API services do not wrap the older ones, so events that...

Supported properties are system/user properties and `packaging`, but `project.version` is not one of those.

Note that `mvnd` does translate (only the current directory) when running in Cygwin, see https://github.com/apache/maven-mvnd/blob/7b309de9ab8e8ed4e65cb43f59c9a3e22edc69e0/daemon/src/main/java/org/mvndaemon/mvnd/cli/EnvHelper.java#L97-L109