Ignoring installation the first time, will cause an installation failure next time

[bougsid]

Expected Behavior

When the user tries to install the app for the first time (before clicking the install button), a user record will be created on DB with an empty password, if the user ignores the installation (Did not click install), and come back later to install the app he should be redirected to the install page again to click the Install button and authorize the app.

Current Behavior

If the user ignores the installation for the first time and comes back later to install the app, he will get a Shopify error page (There’s no page at this address).

Failure Information

I did some investigation, I think the issue is related to the checkPreviousInstallation method on VerifyShopify middleware, this function only checks if the record is presented on DB, and didn't check if the password is there or not, because an empty password means installation not completed yet, the user should be redirected to install page again.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

1. Visit https://domain.com/?shop=yourshop.myshopify.com to install the app for the first time.
2. You will be redirected to the installation page, just ignore and close it.
3. Visit again https://domain.com/?shop=yourshop.myshopify.com, a Shopify error page will be presented.

Context

"osiset/laravel-shopify": "^17.0.0", "laravel/framework": "^8.0",

• Laradock

[gnikyt]

Will look into this.

[yasir-naseer-tetralogicx]

My app got rejected by shopify due to this issue, they did the same steps as mentioned above and they got the same issue for installation. kindly look into this

[clydesantiago]

Created a PR https://github.com/osiset/laravel-shopify/pull/933

[clydesantiago]

@osiset @yasir-naseer-tetralogicx you can close this issue now.

[bougsid]

@osiset any idea when the next release will be?

[Kyon147]

Closing as this issue should be fixed now.