laravel-shopify icon indicating copy to clipboard operation
laravel-shopify copied to clipboard

Possible vulnerability "HelloThinkPHP21"?

Open justenh opened this issue 4 years ago • 5 comments

This morning I received a notification from our error reporting service, Flare. It appears that someone tried to access our app in a way that triggered an Exception within the AuthShopify middleware. Details below, including a screenshot.

I'm not sure if this is anything, but the fact that it threw the exception seems like a red-flag. Any insight you could provide would be greatly appreciated!

ErrorException Array to string conversion

Request [GET] https://myapp.com/index.php/?function=call_user_func_array&s=%2FIndex%2F%5Cthink%5Capp%2Finvokefunction&vars%5B0%5D=md5&vars%5B1%5D%5B0%5D=HelloThinkPHP21

vendor/osiset/laravel-shopify/src/ShopifyApp/Http/Middleware/AuthShopify

Screen Shot 2021-02-10 at 9 07 30 AM

justenh avatar Feb 10 '21 15:02 justenh

Nothing to worry about here I dont believe. The query data is used to calculate an HMAC, its not "ran", just checked.

gnikyt avatar Feb 11 '21 13:02 gnikyt

@osiset Thanks for confirming.

justenh avatar Feb 11 '21 17:02 justenh

@osiset Thanks again for your previous response. I'd like to resurface this issue. The app in question has had new activity that I believe is related to this exception being logged. However, I would like to avoid posting the details publicly until it's been discussed. Is it possible to connect with you via Slack or another channel? Your help would be greatly appreciated as we attempt to determine the severity of this particular scenario.

justenh avatar Jan 07 '22 15:01 justenh

Hi @justenh - is this still an issue? Just cleaning up some stale issues.

Kyon147 avatar Mar 22 '22 12:03 Kyon147

@Kyon147 The original issue is still occurring. I'm unsure if it was part of a larger security issue that we worked through, but believe it could be. Thanks for updating.

justenh avatar Mar 22 '22 21:03 justenh

AuthShopfy is the older package's authentication, I'd advise upgrading to the latest version.

Kyon147 avatar Sep 11 '22 07:09 Kyon147