Basic-Shopify-API icon indicating copy to clipboard operation
Basic-Shopify-API copied to clipboard

Published 20 hours ago • verified publisher icon gnikyt

ResponseAccess::current() should be compatible with Iterator::current()

Open HugoHeneault opened this issue 2 years ago • 6 comments

Hi there,

Thanks for this great API!

I had a few error messages using PHP 8.1 like Return type of Osiset\BasicShopifyAPI\ResponseAccess::current() should either be compatible with Iterator::current(): mixed

This fixes it :)

HugoHeneault avatar Dec 29 '21 15:12 HugoHeneault

@osiset Any chance we can get this merged? We're noticing this deprecation error since switching to PHP 8.1.

chrisnetonline avatar Mar 09 '22 14:03 chrisnetonline

I'm not using it on PHP 8.1 anymore but I think there are more cases I haven't fixed. Feel free to update my PR :)

HugoHeneault avatar Mar 10 '22 09:03 HugoHeneault

@osiset any chance this can be merged?

abishekrsrikaanth avatar Mar 21 '22 20:03 abishekrsrikaanth

Verified, this PR solves the depreciation issues with php 8.1. Please merge

JoshHighland avatar Aug 02 '22 02:08 JoshHighland

@osiset Is there anyone who can marge these changes if you're too busy at the moment?

bretto36 avatar Aug 02 '22 09:08 bretto36

@osiset Hi is there anything stopping this from being merged?

MrDellimore avatar Aug 13 '22 02:08 MrDellimore