LookingGlass icon indicating copy to clipboard operation
LookingGlass copied to clipboard

Add a parameter to hide the waiting message in the GUI

Open RodoMa92 opened this issue 1 year ago • 4 comments

Just a small change to hide the popup messagebox in the UI while waiting.

RodoMa92 avatar Nov 04 '24 14:11 RodoMa92

It should be all good to go, now. Let me know if you need additional changes merged here.

RodoMa92 avatar Nov 05 '24 18:11 RodoMa92

Ready to merge this, just a conflict in AUTHORS needs correcting.

gnif avatar Mar 05 '25 00:03 gnif

@RodoMa92 In doc/usage.rst, adjust the disableWaitingMessage description and make sure the word "disable" has a "s." You could also just make it more direct: "Disables the confirmation message for a cleaner UI." Also instead of "cleaner" you could use "minimal" potentially.

Scrut1ny avatar Mar 24 '25 19:03 Scrut1ny

@RodoMa92 In doc/usage.rst, adjust the disableWaitingMessage description and make sure the word "disable" has a "s." You could also just make it more direct: "Disables the confirmation message for a cleaner UI." Also instead of "cleaner" you could use "minimal" potentially.

usage.rst has a table produced from running looking-glass-client --rst-help

I definitely seem to have missed the discrepancy, so thanks, but it's as simple as rebuilding the client and running that command again

JJRcop avatar Mar 25 '25 09:03 JJRcop

Does anything more have to be done before this can be merged?

It would be helpful to disable that message.

rennr avatar Jun 27 '25 23:06 rennr

Does anything more have to be done before this can be merged?

It would be helpful to disable that message.

Ready to merge this, just a conflict in AUTHORS needs correcting.

gnif avatar Jun 28 '25 03:06 gnif

It should be ready to merge now.

RodoMa92 avatar Jun 28 '25 06:06 RodoMa92

Formatting issue with documentation

Should be fixed now for good.

RodoMa92 avatar Jun 28 '25 07:06 RodoMa92

Sorry but your PR should not introduce a problem and then fix it with another commit, this creates useless noise in the master repository. Please amend your commits, squash those that are not needed, and force-push a clean set of commits for merge.

gnif avatar Jun 28 '25 07:06 gnif

Should be cleaned up now.

RodoMa92 avatar Jun 28 '25 15:06 RodoMa92