LookingGlass icon indicating copy to clipboard operation
LookingGlass copied to clipboard

Install .desktop file and additional icon sizes for client

Open snowkat opened this issue 2 years ago • 4 comments

This installs "Looking Glass Client" to the System menu category along with various sizes of the icon.

snowkat avatar Jul 10 '22 21:07 snowkat

Should these images instead be generated using a source image and maybe something like imagemagick during make install?

JJRcop avatar Jul 12 '22 02:07 JJRcop

This is also the wrong icon, it needs updating to use https://github.com/gnif/LookingGlass/blob/master/resources/lg-logo.svg

gnif avatar Jul 12 '22 21:07 gnif

Should these images instead be generated using a source image and maybe something like imagemagick during make install?

I converted them on my end to avoid having a build-time dependency on imagemagick. If dynamically generating them is preferred, I can modify the functionality for that.

This is also the wrong icon, it needs updating to use https://github.com/gnif/LookingGlass/blob/master/resources/lg-logo.svg

Good to know. Since SVG support is optional (per https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#directory_layout), would it be safe to use https://github.com/gnif/LookingGlass/blob/master/resources/lg-logo.png in addition for systems which don't support SVG icons?

snowkat avatar Jul 13 '22 00:07 snowkat

I converted them on my end to avoid having a build-time dependency on imagemagick. If dynamically generating them is preferred, I can modify the functionality for that.

I don't think we need to do such a think, just simply re-generate them and commit them to the repository.

would it be safe to use https://github.com/gnif/LookingGlass/blob/master/resources/lg-logo.png in addition for systems which don't support SVG icons?

Yes provided it is updated first :)

gnif avatar Sep 18 '22 00:09 gnif