scarpet Stop player from exiting World Border using /cam

Changes made by @altrisi, this prevents someone from leaving a world's world border using /cam

May 09 '22 21:05 LarveyOfficial

Well currently it does this by turning off the cam. Would it be better to just block them from going further? Also if ur going to do this, then perhaps add a note in the Readme.md as well as an action bar message telling the player like "you went out of the world border" or smth?

May 10 '22 20:05 Ghoulboy78

Well currently it doesn't do anything. It just allows the spectator to infinitely go past the border. This just instantly evokes /cam to reset their location and gamemode

Jun 12 '22 06:06 LarveyOfficial

I mean that in the current version of this app it just shuts off cam when the player tries to exit the world border. I'm proposing just blocking them at the world border, and also giving them a message saying that "you're trying to exit the world border" or smth

Jun 12 '22 08:06 Ghoulboy78

We considered that, but it can be messy at times. After some discussion we came to the conclusion that just disabling cam at the border and having them tp back to their original position would overall be better.

Jun 12 '22 13:06 LarveyOfficial

We considered that, but it can be messy at times. After some discussion we came to the conclusion that just disabling cam at the border and having them tp back to their original position would overall be better.

This also prevents annoying players from trying to "bug" past the border even if they can't, although a message stating they can't pass the border may be a good idea.

Jun 12 '22 18:06 LarveyOfficial

thst seems like a better idea

Jun 13 '22 15:06 Ghoulboy78

Which seems like a better idea?

Jun 15 '22 05:06 LarveyOfficial

Turning off cam and also sending a message to the player to tell them why

Jun 16 '22 08:06 Ghoulboy78

Ah yes that's probably the best idea. But like I pointed out at the start of the PR I don't know the syntax, the changes where made by @altrisi

Jun 17 '22 15:06 LarveyOfficial

I have made the changes

Jun 20 '22 09:06 Ghoulboy78

Looks good!

Jun 27 '22 17:06 LarveyOfficial

I'm not going to give an approval to this btw, it would feel like cheating given I wrote most of it (and authors can't self approve).

So this is missing one approval.

Jun 27 '22 17:06 altrisi

I'm not going to give an approval to this btw, it would feel like cheating given I wrote most of it (and authors can't self approve).

So this is missing one approval.

That's fair, we can probably wait for another dev to approve it. I understand your reasoning.

Jun 27 '22 17:06 LarveyOfficial