scarpet icon indicating copy to clipboard operation
scarpet copied to clipboard

world_map fixes for 1.18

Open random-j-farmer opened this issue 3 years ago • 3 comments

A relatively clean fix for the 1.18 breakage.

Fixes #280

Still works in 1.17.1, I did not test with older versions because I deleted my old mod folders at one point.

For the new biomes, I just copied configuration for existing, somewhat similiar biomes.

global_biome_data:'meadow' = global_biome_data:'plains';
global_biome_data:'grove' = global_biome_data:'taiga_hills';
global_biome_data:'snowy_slopes' = global_biome_data:'snowy_mountains';
global_biome_data:'jagged_peaks' = global_biome_data:'snowy_mountains';
global_biome_data:'stony_peaks' = global_biome_data:'mountains';

This does not add visual markers for the new features (Lush & Dripstone Caves, Geodes, ...). I would like to have that, but I also want to play the game this weekend ;)

random-j-farmer avatar Jan 08 '22 21:01 random-j-farmer

Note for future reviewers (incl. self): biome(<biome>, 'category') has been removed in 1.19, so to properly test this you need to run on 1.18(.2 quite sure would work too). 1.19 compat can be looked into later, it shouldn't block this.

BTW sorry about being super slow with PRs! Thanks for contributing even if it's not in yet!

altrisi avatar Sep 22 '22 18:09 altrisi

It doesn't work in any version above 1.18.2, cos certain key features were removed. For higher versions it would likely have to be rewritten entirely.

Ghoulboy78 avatar Feb 13 '23 21:02 Ghoulboy78

It doesn't work in any version above 1.18.2, cos certain key features were removed. For higher versions it would likely have to be rewritten entirely.

Yep I figured as much.

1.19 compat can be looked into later

rv3r avatar Feb 13 '23 22:02 rv3r