scarpet
scarpet copied to clipboard
gnembon
Add Scarpet Edit Installer
Adds an installer for Scarpet Edit.
The installer works by declaring SE as a dependency and checking before and after whether dependency resolution was actually available in order to provide accurate information and proceed with the languages installation.
Some behavior depends on Ghoulboy78/Scarpet-edit#85 getting into a release, the app depends on a release with the language files in it.
Testing is difficult. Sorry. But it Works on my machine™.
How do I test this? Can I make /script download point to a specific branch in the repo?
Nope, you can't (limitations on how Carpet manages it). You'd need to fork the repo, pull this to the master branch, change the scriptsAppStore (or similar) rule to point to your repo (see how the default one is done for syntax) and then /script download it. However, language installation won't work since it needs an in-dev version of Scarpet Edit (you could change the library to point to the SE PR branch instead of the release if you wanted to test that part too).
Still a draft though, basically because of the language thing not being released yet.
PS: You can also technically modify Carpet to add a StoreSource to every app that doesn't have one (that's how I tested it, can break outside of testing) and then loading it normally.
Yo @altrisi, here's the deal. I could make a new Scarpet-Edit release for this new language installer thing, but the thing is that literally 3 commits have passed since the last release, and it feels kinda awkward to be making a new release. However, if it's absolutely necessary for this, then I can do it (in like a 1.3.1 release or something). Could you please let me know then whether or not a release containing the changes in Ghoulboy78/Scarpet-Edit#85 is necessary for this to go through?
A new release is not necessary, only adding the language files to the current one to prevent it failing (just languages won't be installed until then).
I'm also planning to make one or two PRs there in the near future, one being automated language selection.
Also this is on hold basically while waiting for release or a pair more changes there, no rush.
~~Just fix https://github.com/Ghoulboy78/Scarpet-edit/issues/62 and we can do 1.4 release.~~
Only adding the language files to the current one to prevent it failing (just languages won't be installed until then).
Do you mean adding the language files to the release page along with the app itself? If so I can easily do that.