fabric-carpet icon indicating copy to clipboard operation
fabric-carpet copied to clipboard

Changing __on_player_message to not trigger for commands and add event for that

Open Ghoulboy78 opened this issue 2 years ago • 9 comments

Fixes #1511

Ghoulboy78 avatar Aug 05 '22 08:08 Ghoulboy78

I think it would be better to split them into two events. Vanilla handles them seperately, and most of the time, scripts would want to check whether the message is a command or not anyway. This is impossible here, since (iirc) the commands get sent without the /

replaceitem avatar Aug 10 '22 15:08 replaceitem

Yes they do

Ghoulboy78 avatar Aug 10 '22 15:08 Ghoulboy78

Then missing docs + docs update + pr title update.

Though it's worth considering given it'll break apps relying on the other event triggering for commands.

altrisi avatar Aug 11 '22 10:08 altrisi

vanilla splits it into two for reasons that are irrelevant at this level. But it would make sense to split them to two events - I am ok with either.

but as altrisi says: missing docs, update editor keywords, update event_test.sc, and that would be it.

gnembon avatar Aug 22 '22 22:08 gnembon

Yep

Ghoulboy78 avatar Aug 23 '22 08:08 Ghoulboy78

Build failed :(

altrisi avatar Nov 05 '22 11:11 altrisi

oh bruh

Ghoulboy78 avatar Nov 06 '22 17:11 Ghoulboy78

OOh I see the issue. Somehow the latest version of the code got lost somewhere. Lemme fix rq

Ghoulboy78 avatar Nov 06 '22 17:11 Ghoulboy78

Actually, it appears that the events API was updated, and I didn't notice when resolving conflicts. fixed now

Ghoulboy78 avatar Nov 06 '22 17:11 Ghoulboy78

idk why this wasn't merged already

altrisi avatar Dec 26 '22 14:12 altrisi

Oh it's not cancellable. Well I don't think that's that bad tbh

altrisi avatar Dec 26 '22 14:12 altrisi