fabric-carpet
fabric-carpet copied to clipboard
Changing __on_player_message to not trigger for commands and add event for that
Fixes #1511
I think it would be better to split them into two events. Vanilla handles them seperately, and most of the time, scripts would want to check whether the message is a command or not anyway. This is impossible here, since (iirc) the commands get sent without the /
Yes they do
Then missing docs + docs update + pr title update.
Though it's worth considering given it'll break apps relying on the other event triggering for commands.
vanilla splits it into two for reasons that are irrelevant at this level. But it would make sense to split them to two events - I am ok with either.
but as altrisi says: missing docs, update editor keywords, update event_test.sc, and that would be it.
Yep
Build failed :(
oh bruh
OOh I see the issue. Somehow the latest version of the code got lost somewhere. Lemme fix rq
Actually, it appears that the events API was updated, and I didn't notice when resolving conflicts. fixed now
idk why this wasn't merged already
Oh it's not cancellable. Well I don't think that's that bad tbh