Nathanael Noblet

Results 59 comments of Nathanael Noblet

Yeah all the function names should be adjusted accordingly once the variable name is changed.

As for tests, there are some already in the Tests directory, I would suggest there should be a Tests/Translation/UpdaterTest.php file created that runs one or two tests with the switch...

Hey @Nyholm should we get a PR that uses DIRECTORY_SEPARATOR so that tests function on windows when dealing with the paths?

I've rebased off your latest changes. Any chance this could get merged in?

> What I've done: > > * Rename `CommandHandler::handle()` to `__invoke()` > * Rename `EventSubscriber::notify()` to `__invoke()` > * Make sure every handler implements `MessageHandlerInterface` (marker interface) > * Write...

Modify composer.json ``` - "simple-bus/symfony-bridge": "^5.2", + "symfony/messenger": "^5.0", ``` For each command object implement `Symfony\Component\Messenger\Handler\MessageHandlerInterface;` If your handlers previously were defined in a services.yaml file like so: ``` ns.some_handler:...

I'm on Fedora 40, podman 5.1.0 my container's NetworkMode is "bridge". I did add the following to `~/.config/containers/containers.conf` ``` [engine] network_cmd_options=["allow_host_loopback=true"] ``` I have a multi-pod setup php-fpm,mysql,nginx etc. From...

@ssnepenthe Thank you for the very detailed response and even looking at some of the potential issues. I can confirm that when I change the network back to slirp4netns I...

Can you take a look at the failing tests and update to fix?

Just out of curiosity what happens if you make the jms_translation.loader_manager a public service by manually editing the services.xml in the bundle? Does that work? I'm also wondering how this...