Nathanael Noblet

Results 43 comments of Nathanael Noblet

What is the use case for this? Why does it matter when the validation occurs?

the other issue with this change is that the choice_translation_domain doesn't exist as a valid option for sf 2.3 which for whatever reason this bundle still supports even though 2.3...

Well the tests will be trying to pass an option that doesn't exist in 2.3. So if we don't drop 2.3 support we need to then only conditionally run those...

Can you rebase this on master please?

Can you review the test failures and see if you can fix/determine the issue?

This looks like a pretty simple change, I'm wondering however if there's a way to test the changes / results of the setting being set etc.

Yeah, the issue is I have some objects with annotations acting one way and other objects acting a different way so if I can ask. Serializing to json what should...

Ok for example, checkout https://github.com/gnat42/serializerTest . composer install ./vendor/bin/phpunit One will pass and one will fail. However since the objects both have SerializedName, I would expect the output to have...

Ok, so I've learned more and I don't know if this is a bug however it sure *feels* like one to me. In `src/GraphNavigator/SerializationGraphNavigator.php` line 219 there is this call...

Looks interesting. One small nitpick that I left in the comments about the variable name. I'd be ready to merge this feature except it is missing tests and it would...