Nathaniel Sabanski
Nathaniel Sabanski
I strongly feel we need to entertain a merge on this or #944 if for no other reason that: 1. This is an inevitable stumbling block nearly every Starlette user...
> but I think it solves the issue for things that use it inside of BaseHTTPMiddleware which is most of the cases where users encounter this. The necessity has been...
For reference I do believe this is the pattern employed by sanic: Task group outside of the middleware stack. https://sanic.dev/en/guide/basics/tasks.html Seems sound.
One way I've worked around this temporarily is retrieving the form data upfront via middleware. I feel this is not well documented (or intuitive?) for such a common use case...
Note to anyone using the middleware workaround: There's a sizeable performance hit for using `await request.form()` on pages that do not need it. You can restrict this call to only...
Yes, it's entirely related to #944 #1519 An Authentication check requires retrieving POST data. Retrieving POST data requires consuming the stream.
Converted it over to pure ASGI awhile ago. The core issue is unfortunately unrelated. I am beginning to feel like everyone uses Starlette for API's and not websites. :laughing: Being...
To be fair, this is not a showstopping bug, just a poor developer experience. Caching the stream using middleware works, its just not obvious for newcomers to do that. Other...
The desired UX here is: :arrow_right: User visits page, clicks "login" modal in the page header. :arrow_right: User POSTS using that modal `` page refresh (or AJAX). :arrow_right: User is...
Gonna go ahead and close this, but to people searching Github Issues for this DX problem, feel free to leave comments, ideas, discussion, code.