gnverifier icon indicating copy to clipboard operation
gnverifier copied to clipboard

VASCAN wrong processing of classificationPath, Ranks and Ids

Open BenMerSci opened this issue 8 months ago • 1 comments

The requests from VASCAN seems to be populated with wrongful entries for the keys classificationPath, classificationRanks and classificationIds, an example with Viola septentrionalis: https://verifier.globalnames.org/api/v1/verifications/Viola+septentrionalis+Greene?capitalize=true&all_matches=true&data_sources=147

By looking at the entry on VASCAN for Viola septentrionalis (https://data.canadensys.net/vascan/name/Viola%20septentrionalis), I believe it's a problem of how certain ranks are processed (in this case, the subgenus, the section and the subsection seems to be incorrectly parsed).

Looks like it is happening with quite a few other species from VASCAN also.

BenMerSci avatar May 06 '25 18:05 BenMerSci

Thank you for letting me know @BenMerSci, I will investigate

dimus avatar May 07 '25 14:05 dimus

I made the latest import of Vascan and it did seem to fix the problem, would you agree @BenMerSci ? (it is live now)

{
  "metadata": {
    "namesNumber": 1,
    "withAllMatches": true,
    "withCapitalization": true,
    "dataSources": [
      147
    ]
  },
  "names": [
    {
      "id": "0db72576-967c-5f49-9cd4-dfd4900adf97",
      "name": "Viola septentrionalis Greene",
      "cardinality": 2,
      "matchType": "Exact",
      "results": [
        {
          "dataSourceId": 147,
          "dataSourceTitleShort": "VASCAN",
          "curation": "Curated",
          "recordId": "9606",
          "entryDate": "2025-05-19",
          "sortScore": 9.422603222349329,
          "matchedNameID": "0db72576-967c-5f49-9cd4-dfd4900adf97",
          "matchedName": "Viola septentrionalis Greene",
          "matchedCardinality": 2,
          "matchedCanonicalSimple": "Viola septentrionalis",
          "matchedCanonicalFull": "Viola septentrionalis",
          "currentRecordId": "9606",
          "currentNameId": "0db72576-967c-5f49-9cd4-dfd4900adf97",
          "currentName": "Viola septentrionalis Greene",
          "currentCardinality": 2,
          "currentCanonicalSimple": "Viola septentrionalis",
          "currentCanonicalFull": "Viola septentrionalis",
          "taxonomicStatus": "Accepted",
          "isSynonym": false,
          "classificationPath": "Equisetopsida|Magnoliidae|Rosanae|Malpighiales|Violaceae|Violoideae|Violeae|Viola|Viola|Nosphinium|Borealiamericanae|Viola septentrionalis",
          "classificationRanks": "class|subclass|superorder|order|family|subfamily|tribe|genus|subgenus|section|subsection|species",
          "classificationIds": "73|8|11|42|235|342|583|1822|33150|33151|33152|9606",
          "editDistance": 0,
          "stemEditDistance": 0,
          "matchType": "Exact",
          "scoreDetails": {
            "cardinalityScore": 1,
            "infraSpecificRankScore": 0,
            "fuzzyLessScore": 1,
            "curatedDataScore": 0.6666667,
            "authorMatchScore": 0.71428573,
            "acceptedNameScore": 1,
            "parsingQualityScore": 1
          }
        }
      ],
      "curation": "Curated"
    }
  ]
}

dimus avatar May 19 '25 18:05 dimus

Yes this seems to fix the problem! Thank you @dimus !

BenMerSci avatar May 20 '25 12:05 BenMerSci

Great @BenMerSci , I am not adding a test for this one, as it seems to be related to data, not code

dimus avatar May 20 '25 13:05 dimus

Perfect!

BenMerSci avatar May 20 '25 13:05 BenMerSci