remark
remark copied to clipboard
Can not scale well when toggle fullscreen
Hi I wrote a atom plugin slides-preview to preview remarkjs slides when writing markdown. But the slide can not scale well when toggle fullscreen.
I think this may caused by calculating scaling before the window going fullscreen
function handleFullscreen(self) {
var requestFullscreen = utils.getPrefixedProperty(self.containerElement, 'requestFullScreen')
, cancelFullscreen = utils.getPrefixedProperty(document, 'cancelFullScreen')
;
self.events.on('toggleFullscreen', function () {
var fullscreenElement = utils.getPrefixedProperty(document, 'fullscreenElement') ||
utils.getPrefixedProperty(document, 'fullScreenElement');
if (!fullscreenElement && requestFullscreen) {
requestFullscreen.call(self.containerElement, Element.ALLOW_KEYBOARD_INPUT);
}
else if (cancelFullscreen) {
cancelFullscreen.call(document);
}
self.scaleElements();
});
}
requestFullscreen.call
is an async call. It may occur after calling self.scaleElements
. I am not very familiar with javascript, so I am wondering if I am right ?