cli-testing-library icon indicating copy to clipboard operation
cli-testing-library copied to clipboard

Ensure the sub-process exits before the parent process by removing the unref call

Open JakeChampion opened this issue 1 year ago • 0 comments

by using unref, we were introducing a race condition between the parent process exiting and the sub-process exiting - by removing the unref we also remove the race condition as the sub-process will cause the parent process to stay active whilst the sub-process is active. This is likely the correct approach we want to take, if a sub-process is hanging, that is likely an issue the project using cli-testing-library will want to fix as it shows the test is not actually working as they expect it to.

JakeChampion avatar Nov 22 '22 16:11 JakeChampion