Graciliano Monteiro Passos comments

Results 119 comments of


                                            Graciliano Monteiro Passos

Faster dev cycle

@davidmorgan I’ve added your `dependency_overrides` to our backend project, which requires reflection files to be generated. **NOTE:** This is a preliminary benchmark and should not be considered final until all...

Add context to Response for including file and file_not_found to be identified by other shelf Middleware.

> Need some tests here, sir. - Implemented context for directories. - Tests: done ✅

Add context to Response for including file and file_not_found to be identified by other shelf Middleware.

It's the path separator ``` test\symbolic_link_test.dart: access outside of root disabled access real file (failed) Expected: { 'shelf_static:file': 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\dart_test_ee1d415b\\originals/index.html' } Actual: { 'shelf_static:file': 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\dart_test_ee1d415b\\originals\\index.html' } Which: at location ['shelf_static:file'] is...

Add context to Response for including file and file_not_found to be identified by other shelf Middleware.

Should be fixed now. I was using path.join in a completely wrong way: ``` p.join(d.sandbox, 'foo/file.txt') ``` 😅

Add context to Response for including file and file_not_found to be identified by other shelf Middleware.

...needed an extra fix for `createFileHandler`, since it derivates the `File` path from the url.path

Add context to Response for including file and file_not_found to be identified by other shelf Middleware.

Is it ready for publishing?

Add context to Response for including file and file_not_found to be identified by other shelf Middleware.

> I'd like other eyes on this change first @gmpassos Does the code need any adjustments? Best regards.

Add context to Response for including file and file_not_found to be identified by other shelf Middleware.

Any update? Best regards.

Add context to `Response` for including `file` and `file_not_found` to be identified by other `shelf` `Middleware`.

With the `Response.context` populated with the processed `File`, other `Middleware` can manipulate the `Response` in an optimized way and also ensure the correct processed `File`. Without that, another `Middleware` would...

Add context to `Response` for including `file` and `file_not_found` to be identified by other `shelf` `Middleware`.

In my use case, I maintain an in-memory cache of `shelf` `Response`s. Then I need to verify if the cached `Response` `File` has changed using `File.stat`. However, my `Middleware` currently...