nix-flatpak icon indicating copy to clipboard operation
nix-flatpak copied to clipboard

[Question] Will nix-flatpak ever be upstreamed to nixpkgs?

Open SpiderUnderUrBed opened this issue 1 year ago • 4 comments
trafficstars

Will nix-flatpak every be upstreamed to nixpkgs? There has been no offical statement on the wiki and I am curious, of course I dont expect anyone to like, do the work for me, I am just asking out of curiosity, because on the wiki there has been talks of the secure boot module being up-streamed, and many other modules, nix-flatpak makes more sense to be up streamed than any of them. Are there any plans to upstream this?

SpiderUnderUrBed avatar Aug 27 '24 12:08 SpiderUnderUrBed

I find this very unlikely. nix-flatpak and other nix flatpak management solutions (that I've found, anyway) don't seem to be 100% reproducible in the nix way.

baduhai avatar Aug 31 '24 13:08 baduhai

I am not involved with nixos/nixpkgs development, but I don't see a path to upstream.

The approach followed by nix-flatpak does indeed break reproducibility guarantees that nix provides. This project is more more similar (in spirit) to nix-darwin, which also exists as a standalone product.

gmodena avatar Sep 05 '24 11:09 gmodena

Would enforcing commit hashes to pin the flatpaks to a specific version still break reproducubility? I skimmed through the code and it seems that it would guarantee that flatpak installs the exact packages between to invocations.

Thank you for this package!

mainrs avatar Apr 09 '25 10:04 mainrs

Hey @mainrs

Would enforcing commit hashes to pin the flatpaks to a specific version still break reproducubility?

Pinning packages should help with reproducbility, to the degree of which specific versions ( commit hashses) are available in the remote. nix-flatpak does support pinning a specific package version, but could probably benefit from better integration with masking (https://github.com/gmodena/nix-flatpak/issues/154).

Right now if you pin a commit with nix-flatpak and manually run a flatpak update, the pinning will be ignored.

I skimmed through the code and it seems that it would guarantee that flatpak installs the exact packages between to invocations.

Yes; modulo bugs nix-flatpak should provide idempotent, side-effect free installations.

Thank you for this package!

Glad you find it useful!

gmodena avatar Apr 14 '25 19:04 gmodena

Did anyone notice this PR => https://github.com/NixOS/nixpkgs/pull/347605

boustanihani avatar Jul 18 '25 11:07 boustanihani