omf-python icon indicating copy to clipboard operation
omf-python copied to clipboard
verified publisher icon gmggroup

Update SurfaceGrid API to ensure it is in line with new block models

Open fwkoch opened this issue 6 years ago • 1 comments

We need to make sure the SurfaceGrid API is updated for consistency with the new block model API. Also, worth considering if we need new "sub-gridded" surfaces, equivalent to octree/arbitrary sub blocks? Probably not but worth a discussion.

Inspired by @banesullivan's comment - https://github.com/gmggroup/omf/pull/65#discussion_r265816383

fwkoch avatar Mar 28 '19 09:03 fwkoch

Having a RegularSurfaceGridElement would be useful as some grid formats only use regular spacing. Would it be possible to add support for delination/faults in these new Surface Grid elements. I'm not really sure how you would represent these. Maybe if Z == DBL_MAX or have a separate (optional) bool array alongside the Z values to specify if the cell exists.

dbrookes96 avatar May 09 '19 05:05 dbrookes96