George Melikov

Results 71 comments of George Melikov

FreeBSD build failure looks unrelated at first glance ``` /var/lib/buildbot/slaves/zfs/FreeBSD_stable_13_amd64__TEST_/build/zfs/module/os/freebsd/zfs/zfs_acl.c:1681:12: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] domain = ```

@freqlabs thank you, looks like it's the latest one in master, rebased. Besides, at least functional tests are pretty flaky with this change, I'll look at fresh run and try...

@behlendorf done, looks like zloop fails on same problem as is on master ``` dsl_dataset_feature_is_active(ds, f) == B_TRUE (0x0 == 0x1) ASSERT at module/zfs/dsl_scan.c:2024:dsl_scan_visitbp()/lib/x86_64-linux-gnu/libasan.so.5(+0x6cd40)[0x7fd6abc42d40] ``` same here https://github.com/openzfs/zfs/actions/runs/2831422281 , so...

@fredcooke metadata is checksummed too, so we can't easily change those structs. But you're right, `copies` case may have a room for somewhat hacks to ignore wrong (freed and already...

> Surely a checksum can be recalculated and rewritten too, just as if the file itself is modified, no? Aaand you need to recalculate checksums for all blocks in Merkle...

And we surely need some tests, which was cumbersome in https://github.com/openzfs/zfs/pull/9807

@mafredri i updated the wiki. Indeed, we didn't find problems with Swap on ZFS 0.7 branch for a while.

Some small notes on topic: - IIRC you may preload key once with `zfs load-key [-nr] [-L keylocation] -a | filesystem` https://openzfs.github.io/openzfs-docs/man/8/zfs-load-key.8.html?highlight=encrypt and mount/unmount/etc later - most interesting thing in...

@Nicryc did you install `xcb-util-keysyms` package?

@jversusk bear in mind, that: >Due to the conversion, some features have been removed or modified: >1. The browser window must be active for media keys to be detected. >2....