gmberton
Tests/Formatting/Linting
This repo needs some tests for style and that each model still works (make sure urls aren't down, models still load, etc.). I recommend ruff for formatting/linting and pytest.
Any interest in me adding these?
I agree with all of this. We are using black for linting, and had some internal discussions about moving to ruff. @gmberton has been leading that effort and may have some thoughts.
The tests you mentioned would be very welcome. I do not have a lot of experience with pytest but would be happy to learn. We have some basic, self run tests via benchmark.py --task test to make sure the kpts produce correct homographies (w/in some margin of error).
Perhaps we could add GH Actions as well so these are run automatically?
Agree on all you both said. It would be good to add test, as the current ones can surely be improved. I also don't have experience with pytest so @isaaccorley your help would be more than welcome. And we're probably switching to ruff within one or two weeks, so probably we'll ditch black. Another thing where we might need some help/guidance is proper versioning of the repo, for now we are not doing any of that
Cool yeah I'll work on adding some github actions similar to those used in TorchGeo.
I transitioned from black/isort/flake8/pyupgrade to ruff recently and never looked back. It simplifies a lot of config setup in pyproject.toml also.