qtmodern
qtmodern copied to clipboard
Compiled the resources
Pros
- No need to change the path to the resources for cx_Freeze and PyInstaller
- User will not have to include qtmodern resources when bundling
Cons
- Slower to do iterations on the resources because they now require an additional compile step
All in all makes it a lot "it just works" for users, but requires a bit of extra work from the maintainers.
Well spotted! Should depend on qtpy
also makes it a bit harder for the user to make changes to stylesheet etc, not that that matters for most people, but maybe include the uncompiled resources in the next PyPI release too?
That's a good point, we should maybe do something like this.
https://github.com/Jerakin/qtmodern/compare/compiling_resources...Jerakin:change_style?expand=1
That way they could at least monkey patch in their own stylesheet