Graham Markall

Results 776 comments of Graham Markall

Just starting to look at this, but a general point - although the new pass manager is referred to as such in documentation, discussions, etc., to distinguish it from the...

Another note: With the changes in this PR and https://github.com/gmarkall/numba/tree/npm, I was able to test Numba with the new module pass manager (but not function pass manager). This resulted in:...

A quick summary of changes / work needed towards getting this over the line, from OOB discussion: - [x] The example `npm-usage.py` should be in the `examples` dir, and tidied...

Note to any other reviewers / interested parties: whilst reviewing this, I came across this blog post, which is helpful for understanding the new pass manager and the design behind...

Thanks for all the changes! I just finished another round of review and pushed the small tidy-up / reorganization we discussed. > > The documentation at https://llvmlite.readthedocs.io/en/latest/user-guide/binding/optimization-passes.html needs updating to...

A new to-do list for myself for the next (and hopefully final, or almost final) iteration: - [x] Review / editing / commentary of the examples - [x] Notes on...

> So my concern is which strategy numba will use for this new one? The two coexist for a while, or totally remove the old one. The two will coexist...

Notes on my most recent testing with Numba, using the branch https://github.com/gmarkall/numba/tree/npm: * Tested with the Module Pass Manager replaced to prove the concept for this branch (not the Function...

A quick further note related to my Numba testing branch - on some test runs there are no caching fails, in which case the results look like: ``` Ran 11970...

I just merged `main` to get the changes from #1053, which should turn CI green.