Robert Vasek
Robert Vasek
/retest
I'll push a separate PR that gets go mod in line with what this script expects.
That's all good points Marvin, thanks! While that's true that the stdlib dependencies should be exempt from the checks, we still could check dependencies to modules from k8s.io and make...
Now the output looks like this: ``` Verifying dependency versions in /tmp/ws/kcp/cli/go.mod against /home/rvasek/go/pkg/mod/cache/download/github.com/kcp-dev/kubernetes/@v/v0.0.0-20250313100806-0011b8c72acd.mod Version mismatch: golang.org/x/net is v0.36.0, but v0.26.0 expected ... Continuing because no fatal errors found Verifying...
/test pull-kcp-test-e2e-multiple-runs
`pull-kcp-test-e2e-multiple-runs` failed on: ``` I0416 22:56:29.510259 57563 localproxy.go:193] "rewriting cluster" from="root:e2e-workspace-hl28c" to="2guoo00633d7lvld" fatal error: concurrent map writes goroutine 35815 [running]: k8s.io/kube-openapi/pkg/builder3.(*openAPI).buildDefinitionRecursively(0xc00b1cdd80, {0x3be55c4, 0x33}) /home/prow/go/pkg/mod/k8s.io/[email protected]/pkg/builder3/openapi.go:454 +0x336 k8s.io/kube-openapi/pkg/builder3.(*openAPI).buildDefinitionRecursively(0xc00b1cdd80, {0x3bd37ef, 0x2f}) /home/prow/go/pkg/mod/k8s.io/[email protected]/pkg/builder3/openapi.go:458 +0x3e8...
/test pull-kcp-test-e2e-multiple-runs
Closing, monorepo design keeps dependencies in sync.
Commits more or less clean, and mapping for APIBindings, CRDs and built-in types should work. We're still missing tests though so I'm keeping this in Draft still. @sttts I've added...
I've added unit tests and I feel like the code is ready for a review now. PTAL, thank you!