Results 150 comments of Glyn Normington

There are a couple of potential licenses in use on branches, but the `master` branch claims to be MIT licensed in the README, but there is no LICENSE file. I...

I'd like this feature too because there are seasoned committers on our project and relatively new ones that I want to keep a closer eye on.

The problem with picking a specific limit is that, if long sequences of references have a legitimate usecase, then someone will eventually hit a situation where the limit becomes an...

> @glyn Because it can still be used by bad actors as an attack, even without cyclic references; just generate a tree of depth 1 million. That sounds like a...

Yes, that's the reference to KMS plugins. Secrets are decrypted by Kubernetes using the KMS plugin and then injected into pods as usual.

Hmmm. `./build-all.sh` produces different errors with Rust 1.40.0: ``` Compiling grpc v0.7.0 (path to grpc-rust/grpc) error[E0277]: the trait bound `httpbis::HeaderValue: std::convert::AsRef` is not satisfied --> grpc/src/proto/metadata.rs:78:48 | 78 | true...

> since this MR introduce a new crate dependency, and users can easily implement this helper method in their code. I'm not sure wether we should provide this in yaml...

> @glyn I implemented (d), PTAL Looks reasonable. One downside of this approach now becomes apparent. In: ``` let mut d = Decoder::read(file) let mut e = d.encoding_trap(mytrap) let f...

@mkmik `mut self` is indeed idiomatic rust. It's good the compiler protects us from the issue to some extent. I'm still a bit concerned that `encoding_trap()` both mutates `self` and...

@mkmik I'm just getting back into Rust after a long break, so apologies for my lack of understanding. I'm not sure about: ``` pub fn encoding_trap(self, trap: encoding::types::DecoderTrap) -> YamlDecoder...