Brandon Cheng

Results 111 comments of Brandon Cheng

Hi @cruzdanilo @matthias-henseler, I apologize for missing this for so long. I just realized I was only watching mentions and not all repository activity. That should now be fixed. This...

Thanks for checking that @hongkongkiwi. The agent should output errors to the macOS Console. I would be curious if anything sticks out after opening `Console.app` and filtering for the `GPG...

The agent process is supposed to show a GUI alert if it starts with an error. In case there's something wrong with that mechanism, the stdout/stderr of the agent might...

Thanks. The manual output and the logs look expected. Don't see anything off there. I recognize this next part might be involved to set up, but would narrow down the...

Another thought I have: I wonder if dragging the reminder timeout affects whether the problem happens at all. Since many people are reporting that the "_Test Notification_" button is working,...

Adding a few notes on other considerations I was thinking through when making this PR. ## Alternative: Declaration Map One alternative to project references is to set the [`declarationMap` option](https://www.typescriptlang.org/tsconfig/declarationMap.html)...

@jakebailey If you have any feedback on the changes here or pnpm's `tsconfig.json` setup in general, I'd appreciate your thoughts. Totally optional. 🙂

Force push from 885cae28176d656af3b2db4e5127355498681f93 to f8507669ea606614bb3691a791e859d4570e0e90 removes extra project references from `test/tsconfig.json` that could be loaded through the main `tsconfig.json`. https://github.com/pnpm/pnpm/pull/8128#discussion_r1614034536 Thanks @jakebailey. 🥳

Noticed one more problem while testing this out further. The root `pnpm/tsconfig.json` doesn't have `composite` set. Fixing this by adding project references for the pnpm project directly in `pnpm/test/tsconfig.json` instead...

It does not, but the explicit `tsconfig.json` files for tests make it possible to do something with scripts in the future. ```json { "name": "@pnpm/foo", "scripts": { "typecheck": "tsc --build...