syntax-highlighting icon indicating copy to clipboard operation
syntax-highlighting copied to clipboard

added JSX formatting to JavaScript

Open lukkea opened this issue 5 years ago • 3 comments

Description

This comment by @hbergren prompted me to pull this repo into syntax-highlighting. With a couple of tweeks it's working. I have added a "JSX" option to the menu. I also wondered if there should also be a "React" option that does the same as this, but that seemed unnecessary to me so I didn't do that.

I didn't follow the contributing guidelines in my previous pull request and just realised I hadn't created a dedicated branch to hold the changes (I just used a repo I wasn't going to use for anything else).

I have now done it as Glutanimate requested.

Checklist:

Please replace the space inside the brackets with an x and fill out the ellipses if the following items apply:

  • [x] I've read and understood the contribution guidelines
  • [x] I've tested my changes against at least one of the following Anki builds:
    • [x] Latest standard Anki 2.1 binary build [required for Anki-compatible 2.1 add-ons]
    • [] Latest alternative Anki 2.1 binary build
    • [ ] Latest Anki 2.0 binary build [required for Anki 2.0-compatible add-ons]
  • [x] I've tested my changes on at least one of the following platforms:
    • [ ] Linux, version:
    • [x] Windows, version:
    • [ ] macOS, version:
  • [ ] My changes potentially affect non-desktop platforms, of which I've tested:
    • [ ] AnkiMobile, version:
    • [ ] AnkiDroid, version:
    • [ ] AnkiWeb

lukkea avatar Feb 21 '20 16:02 lukkea

it is unfortunate that they didnt merge this pull request and I was lucky to find it here because I really need JSX support. Thanks a lot @lukkea !

Digital-Coder avatar Apr 15 '21 12:04 Digital-Coder

Hi @lukkea, is there a way we could also create a PR for adding TSX support?

danielvelara avatar Sep 19 '21 19:09 danielvelara

Hi @lukkea, is there a way we could also create a PR for adding TSX support?

Yes - tsx could be added the list, but this PR is around eighteen months old and, along with a couple of others I did in @glutanimate's repos, it doesn't appear to have been seen by any maintainers so I expect it might not be the best way you could spend an hour or so...

lukkea avatar Sep 19 '21 20:09 lukkea