review-heatmap icon indicating copy to clipboard operation
review-heatmap copied to clipboard

[Feature Request] Toggle Week Commencing With Sun/Mon

Open dustywayfarer opened this issue 4 years ago • 2 comments

Some parts of the world recognize Monday as the first day of the week. Other parts of the world recognize Sunday. Having a simple option catering to both world-views is preferred.

dustywayfarer avatar Oct 13 '19 18:10 dustywayfarer

Looks like this can be set at the following line:

https://github.com/glutanimate/review-heatmap/blob/17177a05313abafd161099ca7c2ce8d3798dd600/resources/web/cal-heatmap.js#L65

Unfortunately I'm not familiar enough with Anki addons to get the config setup correctly. However, you should be able to open your addons folder and change it there manually for the time being - I'll do that myself right now :)

guidopetri avatar Nov 22 '19 05:11 guidopetri

The fix that charlesoblack mentions no longer seems to work. I am on master commit 4e64a2f601b73a22061ea9bbe819a79c8e22f8c9, and have tried changing the value of weekStartOnMonday to both 0 as the file comments mention, and also false as seems more obvious by the context. In both cases, the resulting .ankiaddon file file (created via aab build) had the week start on Monday.

Note that in our language, Sunday is literally called "Day First" and Monday is literally called "Day Second" so this is more than a matter of aesthetics for us.

Thank you for the attention to the matter!

dotancohen avatar Feb 09 '20 20:02 dotancohen