pytest-anki icon indicating copy to clipboard operation
pytest-anki copied to clipboard

Remove the maximum Anki version constraint

Open oakkitten opened this issue 4 years ago • 1 comments

Checklist

  • [x] I've verified that I use the latest version of pytest-anki
  • [x] I've checked if anyone else suggested this feature before by looking through the issue reports.

Problem case

This makes it impossible to use the plugin with the newer Anki versions

https://github.com/glutanimate/pytest-anki/blob/3562b655ddbd7327f91432b7e6c322361325f349/pyproject.toml#L34-L35

Solution

Remove the upper constraint. Hopefully the tested plugin defines their own Anki versions...

oakkitten avatar Mar 26 '22 23:03 oakkitten

Hey, thanks for the report! Since pytest-anki is tightly coupled to specific Anki version ranges (i.e. every now and then needs to be manually adjusted to retain support with newer Anki versions), my idea here was to use the upper bound to guarantee Anki version support. However, it's definitely an awkward solution and creates many problems of its own. (In an ideal world you'd have anki and aqt follow SemVer, so that API support would be somewhat codified in major/minor versions, but yeah.)

Let me give this another look and see if I can remove the constraint while still specifying a preferred / tested version of Anki to install.

But as a starter, will raise the minimum constraint to 2.1.49 for now, perhaps 2.1.50 if I have the time to test against it.

glutanimate avatar Mar 27 '22 13:03 glutanimate