glusterfs posix: posix xlator does not respects storage.reserve value (#3637)

posix: posix xlator does not respects storage.reserve value

In a small storage environment (brick_root is < 100G) the POSIX xlator does not respects storage.reserve value.The flag value is set after every 5s basis and so in that window if the client has generated the data the posix xlator does not validate storage.reserve spacee check and allow client to consume the brick space unless the flag has not been set by a posixctxres thread.

Solution: Before doing any writev for an external client check the current free storage space with writev buffer and if it has surpassed the limit return ENOSPC. The priv->write_value parameter has been updated during call unlink and truncate fop also to use the correct value.

Fixes: #3636 Change-Id: I7e174553c22893dd44438f48406e895e13b5db5e Signed-off-by: Mohit Agrawal [email protected]

posix: Resolve reviewer comments

Fixes: #3636 Change-Id: I569b8e5d96f138204d25e9753a92cb19135bd584 Signed-off-by: Mohit Agrawal [email protected]

posix: Calculate file written size based on (pre|post)op block size difference to avoid overwrite cases.

Fixes: #3636 Signed-off-by: Mohit Agrawal [email protected] Change-Id: I87efee72e9cdbd1a20df30b07a6e2587ce0675a6

Change-Id: I87efee72e9cdbd1a20df30b07a6e2587ce0675a6 Signed-off-by: Shwetha K Acharya [email protected]

Sep 13 '22 07:09 Shwetha-Acharya

/recheck smoke

Sep 13 '22 09:09 Shwetha-Acharya

/run regression

Sep 19 '22 06:09 Shwetha-Acharya

1 test(s) failed ./tests/bugs/shard/issue-2038.t

0 test(s) generated core

5 test(s) needed retry ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/basic/ec/ec-data-heal.t ./tests/bugs/replicate/bug-976800.t ./tests/bugs/shard/issue-2038.t

2 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/2884/

Sep 19 '22 10:09 gluster-ant

/run regression

Sep 19 '22 11:09 Shwetha-Acharya

1 test(s) failed ./tests/00-geo-rep/georep-basic-dr-rsync-arbiter.t

0 test(s) generated core

3 test(s) needed retry ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/00-geo-rep/georep-basic-dr-rsync-arbiter.t

2 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/2885/

Sep 19 '22 12:09 gluster-ant

/run regression

Sep 19 '22 12:09 Shwetha-Acharya

1 test(s) failed ./tests/00-geo-rep/georep-basic-rsync-ec.t

0 test(s) generated core

3 test(s) needed retry ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/00-geo-rep/georep-basic-rsync-ec.t

2 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/2886/

Sep 19 '22 13:09 gluster-ant

/run regression

Sep 20 '22 05:09 Shwetha-Acharya

1 test(s) failed ./tests/bugs/shard/issue-2038.t

0 test(s) generated core

6 test(s) needed retry ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/basic/ec/ec-data-heal.t ./tests/bugs/quota/bug-1035576.t ./tests/bugs/replicate/bug-976800.t ./tests/bugs/shard/issue-2038.t

2 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/2887/

Sep 20 '22 09:09 gluster-ant

/run regression

Sep 21 '22 07:09 Shwetha-Acharya

1 test(s) failed ./tests/bugs/posix/bug-1651445.t

0 test(s) generated core

7 test(s) needed retry ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_core_multiplex-limit-issue-151.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/00-geo-rep/georep-basic-dr-rsync.t ./tests/bugs/changelog/bug-1208470.t ./tests/bugs/glusterfs-server/bug-887145.t ./tests/bugs/posix/bug-1651445.t

2 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/2893/

Sep 21 '22 11:09 gluster-ant

/run regression

Sep 27 '22 07:09 Shwetha-Acharya

1 test(s) failed ./tests/bugs/glusterd/daemon-log-level-option.t

0 test(s) generated core

5 test(s) needed retry ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/basic/afr/afr-read-hash-mode.t ./tests/basic/afr/ta-shd.t ./tests/bugs/glusterd/daemon-log-level-option.t

2 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/2911/

Sep 27 '22 09:09 gluster-ant

/run regression

Sep 27 '22 14:09 Shwetha-Acharya

1 test(s) failed ./tests/bugs/replicate/bug-976800.t

0 test(s) generated core

3 test(s) needed retry ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/bugs/replicate/bug-976800.t

2 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/2918/

Sep 27 '22 20:09 gluster-ant

/run regression

Sep 29 '22 07:09 Shwetha-Acharya

1 test(s) failed ./tests/bugs/distribute/bug-1286171.t

0 test(s) generated core

5 test(s) needed retry ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/00-geo-rep/georep-basic-dr-rsync-arbiter.t ./tests/bugs/core/bug-1650403.t ./tests/bugs/distribute/bug-1286171.t

2 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/2928/

Sep 29 '22 17:09 gluster-ant

/run regression

Sep 30 '22 12:09 Shwetha-Acharya

1 test(s) failed ./tests/basic/fuse/active-io-graph-switch.t

0 test(s) generated core

8 test(s) needed retry ./tests/000-flaky/basic_distribute_rebal-all-nodes-migrate.t ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_distribute_bug-1117851.t ./tests/000-flaky/bugs_glusterd_bug-857330/normal.t ./tests/000-flaky/bugs_glusterd_bug-857330/xml.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/basic/ec/self-heal.t ./tests/basic/fuse/active-io-graph-switch.t

6 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_distribute_rebal-all-nodes-migrate.t ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_distribute_bug-1117851.t ./tests/000-flaky/bugs_glusterd_bug-857330/normal.t ./tests/000-flaky/bugs_glusterd_bug-857330/xml.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/2949/

Sep 30 '22 17:09 gluster-ant

/run regression

Oct 04 '22 06:10 Shwetha-Acharya

1 test(s) failed ./tests/bugs/replicate/bug-1586020-mark-dirty-for-entry-txn-on-quorum-failure.t

0 test(s) generated core

6 test(s) needed retry ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/basic/ec/ec-data-heal.t ./tests/basic/quick-read-with-upcall.t ./tests/bugs/glusterd/daemon-log-level-option.t ./tests/bugs/replicate/bug-1586020-mark-dirty-for-entry-txn-on-quorum-failure.t

2 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/2975/

Oct 04 '22 10:10 gluster-ant

/run regression

Oct 06 '22 06:10 Shwetha-Acharya

/run regression

Oct 11 '22 12:10 Shwetha-Acharya

1 test(s) failed ./tests/bugs/glusterd/brick-mux.t

0 test(s) generated core

4 test(s) needed retry ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/basic/quick-read-with-upcall.t ./tests/bugs/glusterd/brick-mux.t

2 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/3010/

Oct 11 '22 15:10 gluster-ant

/run regression

Oct 12 '22 05:10 Shwetha-Acharya

1 test(s) failed ./tests/bugs/shard/issue-2038.t

0 test(s) generated core

4 test(s) needed retry ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/bugs/access-control/bug-958691.t ./tests/bugs/shard/issue-2038.t

2 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/3011/

Oct 12 '22 09:10 gluster-ant

/run regression

Oct 12 '22 09:10 Shwetha-Acharya

1 test(s) failed ./tests/bugs/shard/issue-2038.t

0 test(s) generated core

5 test(s) needed retry ./tests/000-flaky/basic_ec_ec-quorum-count-partial-failure.t ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/00-geo-rep/georep-basic-dr-tarssh.t ./tests/bugs/shard/issue-2038.t

2 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/3012/

Oct 12 '22 13:10 gluster-ant

closing this PR as we are no more merging anything new to release 9

May 16 '23 14:05 Shwetha-Acharya

glusterfs glusterfs copied to clipboard

posix: posix xlator does not respects storage.reserve value (#3637)

glusterfs
glusterfs copied to clipboard