glusterfs icon indicating copy to clipboard operation
glusterfs copied to clipboard

dht_fd_ctx_set() - wrong check for return value (not needed once #3730 is merged!)

Open mykaul opened this issue 2 years ago • 8 comments

If we wish to use the result of __fd_ctx_get() we need to check that ret is zero.

Fixes: #3742 Signed-off-by: Yaniv Kaul [email protected]

mykaul avatar Aug 27 '22 10:08 mykaul

/run regression

mykaul avatar Aug 27 '22 14:08 mykaul

/run regression

mykaul avatar Aug 27 '22 15:08 mykaul

1 test(s) failed ./tests/bugs/core/bug-1650403.t

0 test(s) generated core

6 test(s) needed retry ./tests/000-flaky/basic_afr_split-brain-favorite-child-policy.t ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/000-flaky/glusterd-restart-shd-mux.t ./tests/basic/fencing/fencing-crash-conistency.t ./tests/bugs/core/bug-1650403.t

3 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/000-flaky/glusterd-restart-shd-mux.t https://build.gluster.org/job/gh_centos7-regression/2753/

gluster-ant avatar Aug 27 '22 23:08 gluster-ant

/run regression

mykaul avatar Aug 31 '22 15:08 mykaul

1 test(s) failed ./tests/basic/distribute/spare_file_rebalance.t

0 test(s) generated core

8 test(s) needed retry ./tests/000-flaky/basic_distribute_rebal-all-nodes-migrate.t ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_distribute_bug-1117851.t ./tests/000-flaky/bugs_distribute_bug-1122443.t ./tests/000-flaky/bugs_glusterd_bug-857330/normal.t ./tests/000-flaky/bugs_glusterd_bug-857330/xml.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/basic/distribute/spare_file_rebalance.t

6 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_distribute_rebal-all-nodes-migrate.t ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_distribute_bug-1117851.t ./tests/000-flaky/bugs_glusterd_bug-857330/normal.t ./tests/000-flaky/bugs_glusterd_bug-857330/xml.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/2775/

gluster-ant avatar Sep 01 '22 00:09 gluster-ant

/run regression

xhernandez avatar Sep 09 '22 08:09 xhernandez

Probably we shouldn't merge this because of #3730.

xhernandez avatar Sep 14 '22 14:09 xhernandez

Probably we shouldn't merge this because of #3730.

Correct, but #3730 isn't merged yet.

mykaul avatar Sep 18 '22 16:09 mykaul

#3748 is merged.

mykaul avatar Sep 24 '22 18:09 mykaul