fix issue: #3714 ensure webhooks.json is json format when write {}

[zhudongmei]

Signed-off-by: zhudongmei [email protected]

fix:#3714

[gluster-ant]

Can one of the admins verify this patch?

[gluster-ant]

Can one of the admins verify this patch?

[gluster-ant]

Can one of the admins verify this patch?

[black-dragon74]

What is the benefit of writing to a temp file and then renaming it? How does it help the cause?

[zhudongmei]

What is the benefit of writing to a temp file and then renaming it? How does it help the cause?

user run webhook add cmd in several nodes almost at the same time,it will happen

[black-dragon74]

I think instead of writing to a temp file and then renaming it we could solve the problem in much efficient manner if we use exclusive lock while handling the said file. We already have a helper class LockedOpen defined for the use case. I will submit a patch for the same.

/cc: @xhernandez

Regards

[stale[bot]]

Thank you for your contributions. Noticed that this issue is not having any activity in last ~6 months! We are marking this issue as stale because it has not had recent activity. It will be closed in 2 weeks if no one responds with a comment here.

[stale[bot]]

Closing this issue as there was no update since my last update on issue. If this is an issue which is still valid, feel free to open it.