glusterfs icon indicating copy to clipboard operation
glusterfs copied to clipboard

Published 20 hours ago • verified publisher icon gluster

Reduce variable indirection[afr]

Open harshita-shree opened this issue 2 years ago • 7 comments

Sequence to patch #3532 Reducing variable indirection and making use of more scoped variables when possible in the afr component. Updates: #2986

Change-Id: Ide73d8b5a679e6edd670110f1e3ac3d39347e0e9 Signed-off-by: harshita-shree [email protected]

harshita-shree avatar May 30 '22 13:05 harshita-shree

/run regression

harshita-shree avatar May 31 '22 03:05 harshita-shree

1 test(s) failed ./tests/bugs/glusterfs/bug-867253.t

0 test(s) generated core

3 test(s) needed retry ./tests/000-flaky/basic_afr_split-brain-favorite-child-policy.t ./tests/000-flaky/bugs_core_multiplex-limit-issue-151.t ./tests/bugs/glusterfs/bug-867253.t https://build.gluster.org/job/gh_centos7-regression/2538/

gluster-ant avatar May 31 '22 06:05 gluster-ant

/run regression

harshita-shree avatar May 31 '22 07:05 harshita-shree

/run regression

harshita-shree avatar May 31 '22 13:05 harshita-shree

The changes made are not altering the the logic under the locks implementation. I have only attempted to pass the variables required in the function calls. The logs did suggest a IO error, but I believe I'm not sure if the logs suggest any problems due the changes in the above files.

harshita-shree avatar Jun 25 '22 05:06 harshita-shree

LGTM.

We used to have some website who showed the flakiness of tests, so we can see if that test failed only here, when did it fail last, etc.

mykaul avatar Jun 26 '22 12:06 mykaul

@xhernandez could this patch be merged

harshita-shree avatar Jun 27 '22 05:06 harshita-shree