glusterfs
glusterfs copied to clipboard
libglusterfs, rpc: drop old string data format
Drop GF_DATA_TYPE_STR_OLD
dict data type and related code,
prefer GF_DATA_TYPE_STR
in volgen and serialization.
Signed-off-by: Dmitry Antipov [email protected] Updates: #1000
Are there real reasons for keeping GF_DATA_TYPE_STR_OLD
? Any weird kind of backward compatibility?
CLANG-FORMAT FAILURE: Before merging the patch, this diff needs to be considered for passing clang-format
index 3a02aab17..1c0e843c9 100644
--- a/rpc/xdr/src/glusterfs3.h
+++ b/rpc/xdr/src/glusterfs3.h
@@ -52,7 +52,6 @@
/* refer 2717 */
#define GF_O_PATH 010000000
-
#define XLATE_BIT(from, to, bit) \
do { \
if (from & bit) \
/run regression
/run regression
CLANG-FORMAT FAILURE: Before merging the patch, this diff needs to be considered for passing clang-format
index 1afadc33b..d5dca63d8 100644
--- a/libglusterfs/src/dict.c
+++ b/libglusterfs/src/dict.c
@@ -2875,7 +2875,6 @@ out:
* failure: -errno
*/
-
/**
* dict_unserialize - unserialize a buffer into a dict
*
1 test(s) failed ./tests/bugs/core/bug-1650403.t
0 test(s) generated core
5 test(s) needed retry ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t ./tests/000-flaky/glusterd-restart-shd-mux.t ./tests/basic/afr/ta-shd.t ./tests/bugs/core/bug-1650403.t
2 flaky test(s) marked as success even though they failed ./tests/000-flaky/basic_mount-nfs-auth.t ./tests/000-flaky/bugs_nfs_bug-1116503.t https://build.gluster.org/job/gh_centos7-regression/2471/
/run regression
CLANG-FORMAT FAILURE: Before merging the patch, this diff needs to be considered for passing clang-format
index 1afadc33b..d5dca63d8 100644
--- a/libglusterfs/src/dict.c
+++ b/libglusterfs/src/dict.c
@@ -2875,7 +2875,6 @@ out:
* failure: -errno
*/
-
/**
* dict_unserialize - unserialize a buffer into a dict
*
/run regression
CLANG-FORMAT FAILURE: Before merging the patch, this diff needs to be considered for passing clang-format
index 057d38a23..2c0d48533 100644
--- a/libglusterfs/src/dict.c
+++ b/libglusterfs/src/dict.c
@@ -2835,8 +2835,6 @@ out:
return ret;
}
-
-
/**
* dict_unserialize - unserialize a buffer into a dict
*
diff --git a/libglusterfs/src/glusterfs/dict.h b/libglusterfs/src/glusterfs/dict.h
index 12463b2d6..2365fa9da 100644
--- a/libglusterfs/src/glusterfs/dict.h
+++ b/libglusterfs/src/glusterfs/dict.h
@@ -173,7 +173,6 @@ dict_reset(dict_t *dict);
int
dict_key_count(dict_t *this);
-
int32_t
dict_unserialize(char *buf, int32_t size, dict_t **fill);
Thank you for your contributions. Noticed that this issue is not having any activity in last ~6 months! We are marking this issue as stale because it has not had recent activity. It will be closed in 2 weeks if no one responds with a comment here.
Closing this issue as there was no update since my last update on issue. If this is an issue which is still valid, feel free to open it.