posix-*.c: remove some string copies in posix_handle_pump() and relat…

[mykaul]

…ed functions

• Remove multipls strncpy() from posix_handle_pump(), as well as an strotoul() call.
• Remove redundant 'ret' variable
• posix_handle_path() always gets PATH_MAX path variables, no need to pass size to it.
• Make functions static, etc.

Fixes: #2987 Signed-off-by: Yaniv Kaul [email protected]

[mykaul]

/run regression

[gluster-ant]

1 test(s) failed ./tests/basic/afr/self-heald.t

1 test(s) generated core ./tests/basic/afr/self-heald.t

4 test(s) needed retry ./tests/000-flaky/bugs_glusterd_bug-857330/normal.t ./tests/000-flaky/bugs_glusterd_bug-857330/xml.t ./tests/000-flaky/glusterd-restart-shd-mux.t ./tests/basic/afr/self-heald.t

3 flaky test(s) marked as success even though they failed ./tests/000-flaky/bugs_glusterd_bug-857330/normal.t ./tests/000-flaky/bugs_glusterd_bug-857330/xml.t ./tests/000-flaky/glusterd-restart-shd-mux.t https://build.gluster.org/job/gh_centos7-regression/1871/

[mykaul]

/run regression

[gluster-ant]

1 test(s) failed ./tests/basic/afr/self-heald.t

1 test(s) generated core ./tests/basic/afr/self-heald.t

4 test(s) needed retry ./tests/000-flaky/bugs_glusterd_bug-857330/normal.t ./tests/000-flaky/bugs_glusterd_bug-857330/xml.t ./tests/000-flaky/glusterd-restart-shd-mux.t ./tests/basic/afr/self-heald.t

3 flaky test(s) marked as success even though they failed ./tests/000-flaky/bugs_glusterd_bug-857330/normal.t ./tests/000-flaky/bugs_glusterd_bug-857330/xml.t ./tests/000-flaky/glusterd-restart-shd-mux.t https://build.gluster.org/job/gh_centos7-regression/1884/

[stale[bot]]

Thank you for your contributions. Noticed that this issue is not having any activity in last ~6 months! We are marking this issue as stale because it has not had recent activity. It will be closed in 2 weeks if no one responds with a comment here.

[mykaul]

Hoping to complete it someday...

[stale[bot]]

Thank you for your contributions. Noticed that this issue is not having any activity in last ~6 months! We are marking this issue as stale because it has not had recent activity. It will be closed in 2 weeks if no one responds with a comment here.

[stale[bot]]

Closing this issue as there was no update since my last update on issue. If this is an issue which is still valid, feel free to open it.