gluster-csi-driver icon indicating copy to clipboard operation
gluster-csi-driver copied to clipboard

Take parameters from SC and give preference.

Open humblec opened this issue 7 years ago • 5 comments

At present the parameters for provisioner has been taken from ENV which has to be changed and enabled for SC parameter list. The TODO in the csi driver commit https://github.com/gluster/gluster-csi-driver/blob/master/pkg/glusterfs/controllerserver.go#L59 has to be enabled and given priority over ENV

humblec avatar Aug 30 '18 17:08 humblec

@Madhu-1 I believe I explained this requirement clearly, if not let me know. I can share more details. If it was clear, please send a PR.

humblec avatar Aug 30 '18 17:08 humblec

/assign @Madhu-1

humblec avatar Aug 30 '18 17:08 humblec

I'm still unclear about what benefit this provides to the admin. The CSI driver version (Gluster client) needs to stay in sync with the Gluster container version (Gluster server).

The most straightforward way to accomplish that (automatically, in a scalable way) is by having 1 csi driver instance per Gluster cluster. Going that route, there is no need to repeat the cluster connection info in each StorageClass object. It can be provided to the driver once at startup.

@humblec could you better describe the user value of putting this info in the SC?

JohnStrunk avatar Sep 12 '18 11:09 JohnStrunk

@JohnStrunk @humblec What's the definition of MVP 1.0 label? Is it equivalent to GCS 1.0? If so can you please retag it with GCS/1.0 based on if the work can get completed in 2 week's time?

atinmu avatar Jan 17 '19 11:01 atinmu

This is not a priority for GCS 1.0.

JohnStrunk avatar Jan 17 '19 15:01 JohnStrunk