gluster-csi-driver icon indicating copy to clipboard operation
gluster-csi-driver copied to clipboard

Incorrectly named drivers

Open saad-ali opened this issue 5 years ago • 0 comments

Describe the bug Per the CSI spec the name of a CSI driver must conform to the following requirements:

The name MUST follow domain name notation format (https://tools.ietf.org/html/rfc1035#section-2.3.1).

It SHOULD include the plugin's host company name and the plugin name, to minimize the possibility of collisions.

It MUST be 63 characters or less, beginning and ending with an alphanumeric character ([a-z0-9A-Z]) with dashes (-), dots (.), and alphanumerics between.

This field is REQUIRED.

CSI 0.x required reverse domain notation. But CSI 1.0 dropped the "reverse" part of the requirement. The expectation is that the name will be normal (forward) domain notation.

So for CSI 1.0, instead of org.gluster.glusterfs and org.gluster.glustervirtblock the driver name should be glusterfs.csi.gluster.org and glustervirtblock.csi.gluster.org (I would throw .csi. in there for clarity, but that is optional).

Steps to reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Actual results Describe what happened

Expected behavior A clear and concise description of what you expected to happen.

Additional context Add any other context about the problem here.

saad-ali avatar Apr 13 '19 05:04 saad-ali