gluster-containers
gluster-containers copied to clipboard
gluster
wip: group RUN's, conditionalize starting of services
"wip" is not the right label. It's more a "RFC". If you want to, I can localize the commits into smaller parts. I can also bring the fedora-based image up to date and let it conform to the centos-one, if so desired.
@ibotty I apologize for the delay in getting back to you. Its really appreciated if you can make it in different PRs. so that easy to bring in the changes. Thanks !!!
NP. I'll rework it in the following weeks. Btw: is there a test suite available somewhere?
@ibotty we have some internal tests, but no upstream. I will look into this. Also appreciated if you can break the commits and send PR.
Sorry for not getting back. I will incorporate the comments, split it up and give it a test ride, hopefully next week.
@ibotty looks like u r busy. :). Please let us know if you would like us to move on this with next iteration of this patch.
Oh, Sorry. Yes, I was and am busy. I did run into too many problems with lvm getting confused between host and docker container that I installed in the host directly. So it will be hard for me to dedicate time to this. Sorry for not communicating!
@ibotty @MohamedAshiqrh we use LVM in our setup without issues among host and container. Not sure what issues you are facing in ur setup. Any way we will revisit the PR. Thanks!
@humblec @ibotty Yeah LVM has no issues in my setup. If at all you have time, can you point us what errors you faced. so that we can see how to avoid any such issues.
I don't have the details handy, but LVM's config files in the container and on the host were not consistent, so I got the warning about having to repair a thin pool. On the end instead of debugging that further, I installed on the host.
I would still be willing to rebase this PR, but I won't be able to test the changes. If you are interested, I will do that soon-ish.