gluster-containers icon indicating copy to clipboard operation
gluster-containers copied to clipboard

Why are Fedora and CentOS so vastly out of sync? Do they need to be synced more?

Open obnoxxx opened this issue 6 years ago • 4 comments

The centos and fedora containers are pretty much out of sync.

How the Dockerfile does things

Several things done differently in the container, like how to add files into the container, e.g.:

ADD gluster-setup.sh /usr/sbin/gluster-setup.sh

for centos and

COPY gluster-setup.sh [...] /
...
RUN ...&& \
...
mv /gluster-setup.sh /usr/sbin/gluster-setup.sh && \
...

for fedora, which seems less idiomatic and more complicated. So here a style / technique sync may be good.

Different components

Several mechanisms/components are only added to one of the containers, not both:

Fedora has

  • gluster-setup
  • fake-disk
  • gluster-brickmultiplex

Centos has:

  • gluster-setup
  • fake-disk
  • gluster-block-setup
  • update-params
  • status-probe
  • check-diskspace

Should we reconcile those services as much as possible?

What do people think?

obnoxxx avatar Feb 20 '19 19:02 obnoxxx

@humblec @nixpanic @jarrpa @SaravanaStorageNetwork @phlogistonjohn @raghavendra-talur @Madhu-1 ... what do you guys think?

obnoxxx avatar Feb 20 '19 19:02 obnoxxx

It's worthwhile but the last time I started doing it I got bogged down and never got far enough to make a PR. Maybe it would be best just to pick one (centos probably) and remove the other?

phlogistonjohn avatar Feb 20 '19 21:02 phlogistonjohn

+1 to John's suggestion. If we're not using it, no sense maintaining it.

jarrpa avatar Feb 21 '19 22:02 jarrpa

same opinion here - it is better to maintain single container based on CentOS

SaravanaStorageNetwork avatar Feb 22 '19 03:02 SaravanaStorageNetwork