fsnotes icon indicating copy to clipboard operation
fsnotes copied to clipboard

Remove custom sidebar styles

Open nth-chile opened this issue 1 year ago • 1 comments

Done:

  • The main goal of this PR is to remove the custom styling from the sidebar so that it will fall back to system UI
  • Now if you press the right arrow key to move to the note list, the sidebar item (on dark mode, at least) will go from blue to grey (selected to unemphasizedSelected). I like this because it shows user where the focus is.

Would be nice:

  • I tried to set the sidebar background to NSVisualEffectView.Material.sidebar, which is the slightly transparent material that Mac app sidebars use nowadays (like xCode), but I couldn't get it to work. Maybe there is a background on the ViewController or something that is blocking it?

⚠️ Todo before merging:

  • On light mode, text color is black even when selected. Is there a custom style that's keeping it black? Maybe we need to set it to .selectedTextColor
  • Icon is blue when cell background is blue. Is there a system icon that will automatically change color when selected?
Screenshot 2023-12-30 at 5 21 14 PM Screenshot 2023-12-30 at 5 21 35 PM

nth-chile avatar Dec 30 '23 22:12 nth-chile

The idea is to remove custom styling so we fall back on defaults as much as possible. When we use colors, we can use system colors like NSColor.textColor this will ensure that as macOS evolves, fsnotes will continue to match the appearance of macOS

@glushchenko do you like this idea? If so, I can fix up the todos here, and can make another PR to do the same thing for notes list

nth-chile avatar Jan 01 '24 15:01 nth-chile

I can't test the UI in macOS 10.14, and that has a lot of caveats. It's best not to do that, sorry.

glushchenko avatar Feb 27 '24 19:02 glushchenko