fsnotes icon indicating copy to clipboard operation
fsnotes copied to clipboard

Opening the Notes List context menu locks up the app

Open tewe opened this issue 2 years ago • 7 comments

Description

Opening the context menu on a Notes List item reliably beachballs the app, until force quit.

Spin dump

A workaround is using the File menu, which has most of the same items.

To Reproduce

  1. Two-finger tap on any note in the list

Expected behavior

Have the context menu not just open, but also allow a selection from it, without locking up the app.

FSNotes version

6.1.3 (559)

macOS/iOS version

macOS 12.6.2

Additional context

One difference between the File menu and the context menu is that History is a sub-menu. The spin dump shows a lot of Git. The version I first noticed this with included some changes to the Git code. So that's where I'd look.

tewe avatar Feb 06 '23 23:02 tewe

Ho many commits do you have?

glushchenko avatar Feb 12 '23 22:02 glushchenko

git --git-dir=a7cf...git rev-list --count HEAD says 776.

tewe avatar Feb 14 '23 09:02 tewe

It's not much, it's very strange why that is.

glushchenko avatar Feb 14 '23 09:02 glushchenko

time git --git-dir=a7cf...git/ log -- Some.textbundle/text.md takes 1.6 seconds, which seems long but is much much less than what the app needs.

tewe avatar Feb 19 '23 14:02 tewe

I think I reproduced it, looking for a solution

glushchenko avatar Feb 20 '23 17:02 glushchenko

Please try this https://github.com/glushchenko/fsnotes/releases/download/6.1.4/FSNotes_6.1.4.zip

glushchenko avatar Feb 20 '23 21:02 glushchenko

Unfortunately that didn't help.

Spin dump

I noticed that some notes take longer than others. This seems more related to how long ago the first revision was than to how many there are.

tewe avatar Feb 23 '23 23:02 tewe

I can no longer reproduce this in FSNotes 6.8.0 for macOS. Thanks!

tewe avatar May 29 '24 21:05 tewe