maps icon indicating copy to clipboard operation
maps copied to clipboard

Osm license

Open brunesto opened this issue 4 years ago • 3 comments

Hello this is to resolve #51 - the osm tile usage policy . it does not remove the app, just adds copyright label and changes the way TileRetriever is instanciated

Adding the copyright label is just a couple of lines in MapView

For beeing able to easily use own tile provider (e.g. in the MobileSample class) it required more changes: Basically TileProviderRetriever is gone, instead the TileRetriever has to passed as a constructor arg to MapView and BaseMap. Hence CachedOsmTileRetriever does not have static fields methods anymore.

I wanted to keep the changes small, so 2 further changes are probably needed:

  • Instead of moving CachedOsmTileRetriever around I just modified module-info.java
  • It breaks compatibility, so an empty MapView constructor would be needed

brunesto avatar Oct 21 '20 08:10 brunesto

Hi @brunesto ,

Thank you for the PR. Please sign the Gluon CLA as per the Gluon contribution requirement.

abhinayagarwal avatar Oct 21 '20 15:10 abhinayagarwal

@brunesto We have just merged a pending PR, can you fix the conflicts?

jperedadnr avatar Oct 28 '20 20:10 jperedadnr

@jperedadnr I think it's done

brunesto avatar Oct 29 '20 16:10 brunesto