gluon icon indicating copy to clipboard operation
gluon copied to clipboard

feat: windows user preferred & installed browsers

Open ThaUnknown opened this issue 3 years ago • 1 comments

This PR implements USER not system preferred browsers as a single computer might have multiple accounts with different preferences, it also implements a list of all installed browsers, which would be nice to use for stuff like engine preference, where the developer could define a preferred engine like chromium or gecko and we could try to find that browser in those installed ones.

Windows only

Known issues: getInstalledBrowsers will return html editors like vscode, vsstudio, jetbrains, notepad and notepad++

notably this repository doesn't have an eslint config defined, so I didn't know what coding styles to follow.

addresses #11

I do not believe however that checking by .html is a good idea, imho checking by https is a way better idea, but @CanadaHonk proposed .html files

ThaUnknown avatar Jan 02 '23 17:01 ThaUnknown

checking by https is not a better idea, cause you can have fake browsers, like mine here or even the original project that I forked here

well, the original project declares that it supports html sadly, but mine only declares [http, https] (http and https are the bare minimum you must support for windows to recognize it as a browser)

ArjixWasTaken avatar Jan 03 '23 13:01 ArjixWasTaken

Closing as leaving for the future with a different/better implementation (discussed on Discord).

CanadaHonk avatar Jan 05 '23 13:01 CanadaHonk