gluestack-ui icon indicating copy to clipboard operation
gluestack-ui copied to clipboard

Select: Selected Value is not getting highlighted in native device.

Open Viraj-10 opened this issue 1 year ago • 3 comments

Description

I am seeing a regression on the Select component with the updated version. On 1.1.4, the selected item was highlighted on the ActionSheet (on native), however now on 1.1.6 the selected item is not highlighted at all. Screenshots before and after: Gluestack 1.1.4 iPhone_14-3 Gluestack 1.1.6 iPhone_14-4

CodeSandbox/Snack link

No response

Steps to reproduce

No response

gluestack-ui Version

1.1.6

Platform

  • [X] Expo
  • [ ] React Native CLI
  • [ ] Next
  • [ ] Web
  • [X] Android
  • [X] iOS

Other Platform

No response

Additional Information

No response

Viraj-10 avatar Feb 15 '24 17:02 Viraj-10

Hey @Viraj-10

I've just come across something like this, I've noticed it happening in version 1.1.4 as well not sure why as it seems to be working for you hmm.

I created a brand new repo with the Solito + Gluestack using one of the starters, originally it didn't experience the issue as it was using the following dependencies:

"@gluestack-style/react": "^1.0.15", "@gluestack-ui/config": "^1.0.3", "@gluestack-ui/themed": "^1.0.13",

After upgrading the brand new repo to use my current projects dependencies:

"@gluestack-style/react": "^1.0.47", "@gluestack-ui/config": "^1.1.2", "@gluestack-ui/themed": "^1.1.4",

It experiences the select options not being showing up in the selected state.

AlexMachin1997 avatar Feb 22 '24 10:02 AlexMachin1997

@AlexMachin1997, This issue has been fixed. We have replaced this with checked instead of active. You can check code here.

Viraj-10 avatar Mar 26 '24 07:03 Viraj-10

Hey @Viraj-10 That's great news, I can see its been merged into a branch named "patch" ? Has this been released or is this going to be merged into main pretty soon ?

AlexMachin1997 avatar Mar 27 '24 14:03 AlexMachin1997

This issue is now resolved, so I am closing it. If you have any further questions or issues, please feel free to reopen it. thank you

rajat693 avatar Jul 25 '24 04:07 rajat693