glue-jupyter
glue-jupyter copied to clipboard
WIP: implement log_x and log_y
Start of implementation of https://github.com/spacetelescope/jdaviz/issues/914
TODO:
- [x] bqplot Bar does not handle log y scale correctly
- [ ] bqplot-image-gl does not support log scales
- [ ] the scale_x and scale_y if figure need to be linked to for instance the MouseInteration
Codecov Report
Attention: 20 lines in your changes are missing coverage. Please review.
Comparison is base (
f8e24b8) 86.65% compared to head (3aa2f1a) 75.27%.
:exclamation: Current head 3aa2f1a differs from pull request most recent head 794506f. Consider uploading reports for the commit 794506f to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #273 +/- ##
===========================================
- Coverage 86.65% 75.27% -11.38%
===========================================
Files 89 82 -7
Lines 5154 4190 -964
===========================================
- Hits 4466 3154 -1312
- Misses 688 1036 +348
| Files | Coverage Δ | |
|---|---|---|
| glue_jupyter/bqplot/tests/test_bqplot.py | 100.00% <100.00%> (ø) |
|
| glue_jupyter/view.py | 94.50% <100.00%> (+0.12%) |
:arrow_up: |
| glue_jupyter/__init__.py | 63.23% <12.50%> (-7.26%) |
:arrow_down: |
| glue_jupyter/bqplot/common/viewer.py | 76.71% <65.78%> (-11.57%) |
:arrow_down: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Requires:
- https://github.com/bqplot/bqplot/pull/1424
- https://github.com/bqplot/bqplot/pull/1423