data.tree icon indicating copy to clipboard operation
data.tree copied to clipboard

implemented workaround for issue #160

Open simschul opened this issue 1 year ago • 3 comments

Workaround for the issue in as.Node.data.frame when one node and one column of the data.frame share the same name. Note: the suggested workaround adds a new argument (suffix) to the function, suffixis then pasted to the column name.

simschul avatar Nov 18 '23 11:11 simschul

Hey @simschul Simon, thank you so much. Will look into it! Best, Christoph

gluc avatar Nov 23 '23 12:11 gluc

Hey, I'm getting a WARNING in the check:

* checking Rd \usage sections ... WARNING
Warning: Undocumented arguments in documentation object 'as.Node.data.frame'
  'suffix'

gluc avatar Nov 23 '23 14:11 gluc

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.65%. Comparing base (75dbb9b) to head (c124ab6). Report is 38 commits behind head on master.

Files Patch % Lines
R/node_conversion_dataframe.R 55.55% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   85.06%   84.65%   -0.41%     
==========================================
  Files          16       16              
  Lines         904      932      +28     
==========================================
+ Hits          769      789      +20     
- Misses        135      143       +8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 13 '24 02:07 codecov-commenter