gltf icon indicating copy to clipboard operation
gltf copied to clipboard

Add support for comparing gltfs by implementing PartialEq on Root

Open rydb opened this issue 1 year ago • 2 comments

I am trying to use this library to serialize meshes for my project into the gltf format. In order to confirm I'm doing it correctly, I would like to compare a mesh gltf imported from a working exporter, and the mesh gltf exported from the one I'm working on.

However, currently, I cannot compare gltf files as Root does not implement PartialEq

This pr resolves this by implementing PartialEq on Root and all attributes that Root uses.

rydb avatar Dec 17 '24 00:12 rydb

tried to test the check failures locally with act and I'm getting these two errors

[Tests/Run test]   ❗  ::error::Input required and not supplied: token
[Tests/Run test]   ❌  Failure - Main Checkout glTF Sample Assets

not sure how to fix this.

rydb avatar Jan 13 '25 20:01 rydb

tried to test the check failures locally with act and I'm getting these two errors

[Tests/Run test]   ❗  ::error::Input required and not supplied: token
[Tests/Run test]   ❌  Failure - Main Checkout glTF Sample Assets

not sure how to fix this.

gave test suite auth token and this bug went away. Now waiting on: https://github.com/serde-rs/json/pull/1227

to be merged to finish this pr.

rydb avatar Jan 13 '25 22:01 rydb