glpi-project
Merging Software not possible
Code of Conduct
- [x] I agree to follow this project's Code of Conduct
Is there an existing issue for this?
- [x] I have searched the existing issues
Version
11.0.4
Bug description
When I try to merge one or multiple software packages into the root software packages the select modal doesn't work.
Relevant log output
Page URL
No response
Steps To reproduce
- Select a Software which exists in root entity
- Change the inheritance to "Child entities" and save
- goto the merge window
- select one or all entries in sub entities
- click the action button
if you have not selected the last entry you get an error message that no item has been selected
if you have selected the last entry in the list you get the drop down and can select merge, but after selecting merge you get an error message "No selected items".
Your GLPI setup information
No response
Anything else?
Select all video: https://github.com/user-attachments/assets/a574fe13-2c1b-4085-88a5-2925d708e8e0
Select single item and last item video https://github.com/user-attachments/assets/f7132972-d3f7-431d-bd07-82dd5b420de5
No relevant logs, but I debugged it and found the missing parts:
https://github.com/glpi-project/glpi/blob/634ce36f6900d0811af2953724fceb127479f9eb/src/Software.php#L965-L970
doesn't provide itemtype and id which is needed here:
https://github.com/glpi-project/glpi/blob/634ce36f6900d0811af2953724fceb127479f9eb/templates/components/datatable.html.twig#L237-L241
I allowed my self to create a pr #22354
I don't know if I have to close this issue or it's done automatically or you close it anyway, the pr solves my issue, sorry if the pr is not the correct way.
[...] I allowed my self to create a pr #22354
👍
I don't know if I have to close this issue or it's done automatically or you close it anyway, the pr solves my issue, sorry if the pr is not the correct way.
Issues are closed automatically when related PR is merged; there is nothing more to do for now.